refactor(elasticSearch): simplify query building logic and add new fe…#1270
refactor(elasticSearch): simplify query building logic and add new fe…#1270AfroTechBoss wants to merge 5 commits into
Conversation
…atures - Remove unused geo point and regex functions - Add support for fuzzy queries and proper wildcard escaping - Improve handling of array values and negation cases - Add ES syntax version constants for better version control - Simplify range parameter building and field determination
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c431177:
|
|
Please use pnpm 8 and discard changes to lockfile and package.json |
Ran pnpm 8, discarded changes made to package.json and lock file
Done |
|
Please fix the failing tests. Looks like this failing test indicates issue (regression?) with handling of lists: Could you please add tests for new features (fuzzy queries, wildcard escaping)? https://github.com/ukrbublik/react-awesome-query-builder/tree/master/packages/tests#watch-mode I've removed changes to a lock file from your branch to fix issues with CI (pnpm lock file should have version 6) |
- Add tests for BAD_SELECT_VALUE and B
GM @ukrbublik, I made the changes 2 days ago... |
| }] | ||
| }, config)!; | ||
| const { fixedTree } = Utils.sanitizeTree(tree, config); | ||
| expect(Utils.jsonLogicFormat(fixedTree, config)).to.deep.equal({ |
There was a problem hiding this comment.
You should test the result of exporting to ES format rather than to JsonLogic format.
Utils.elasticSearchFormat(fixedTree, config)
ukrbublik
left a comment
ukrbublik
left a comment
There was a problem hiding this comment.
Sorry but the tests are still failing
https://github.com/ukrbublik/react-awesome-query-builder/actions/runs/15466416744/job/43600521111?pr=1270
2 participants
…atures
closes issue- #1265