alter group paths centrally#2
Open
mfairchild365 wants to merge 1 commit into
Open
Conversation
This will work for any output including json, etc. The `link_alter()` method was only being applied to html output. As far as I can tell with my testing (which might be lacking) this appears to still work in all the same cases that `link_alter()` was implementing. By the time a node/x reaches the `processOutbound()` method in this module, other `processOutbound()` implementations would have already converted it to the /group/blah path, so our `processOutbound()` method will work as expected. This should undergo heavy testing before it is merged, and probably also deserves unit tests
Member
|
Editing a node on a subdomain gives the following when saved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will work for any output including json, etc. The
link_alter()method was only being applied to html output. As far as I can tell with my testing (which might be lacking) this appears to still work in all the same cases thatlink_alter()was implementing. By the time a node/x reaches theprocessOutbound()method in this module, otherprocessOutbound()implementations would have already converted it to the /group/blah path, so ourprocessOutbound()method will work as expected.This should undergo heavy testing before it is merged, and probably also deserves unit tests