Skip to content

perf(pm): remove registry cache hook#3045

Draft
elrrrrrrr wants to merge 1 commit into
perf/pm-split-resolver-remove-preloadfrom
perf/pm-split-resolver-remove-cache-hook
Draft

perf(pm): remove registry cache hook#3045
elrrrrrrr wants to merge 1 commit into
perf/pm-split-resolver-remove-preloadfrom
perf/pm-split-resolver-remove-cache-hook

Conversation

@elrrrrrrr
Copy link
Copy Markdown
Contributor

Summary

  • remove the old RegistryClient::cache_version_manifest preload hook
  • drop the now-unused UnifiedRegistry implementation of that hook
  • keep manifest provider tests intact

Validation

  • cargo fmt
  • cargo check -p utoo-ruborist
  • cargo test -p utoo-ruborist mock_registry_executes_manifest_provider_jobs -- --nocapture
  • cargo test -p utoo-ruborist test_unified_registry_executes_extract_manifest_provider_job -- --nocapture
  • cargo clippy --all-targets -- -D warnings --no-deps

Split Plan

Part of the resolver stack split from source PR #3028. This removes a preload-era cache callback before the registry memory-cache cleanup.

@elrrrrrrr elrrrrrrr added A-Pkg Manager Area: Package Manager benchmark Run pm-bench on PR labels May 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the cache_version_manifest method from the RegistryClient trait and its implementation in UnifiedRegistry. I have no feedback to provide.

@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-preload branch from fedab9c to 3a49840 Compare May 21, 2026 19:26
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-cache-hook branch from ef1f15b to 3f47d7e Compare May 21, 2026 19:27
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-cache-hook branch from 3f47d7e to 6f349ab Compare May 21, 2026 22:32
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-preload branch from 0b4c7d5 to c12fd4c Compare May 21, 2026 23:09
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-cache-hook branch from 6f349ab to 8b02fd5 Compare May 21, 2026 23:09
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-preload branch from c12fd4c to fc7be5f Compare May 21, 2026 23:39
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-cache-hook branch from 8b02fd5 to ed9ee58 Compare May 21, 2026 23:39
@github-actions
Copy link
Copy Markdown

📊 pm-bench-phases · ad420a7 · linux (ubuntu-latest)

Workflow run — ant-design

PMs: utoo (this branch) · utoo-npm (latest published) · bun (latest)

npmjs.org

p0_full_cold

PM wall ±σ user sys RSS pgMinor
bun 7.12s 0.23s 10.45s 6.13s 667M 295.9K
utoo-next 7.17s 0.37s 10.83s 7.86s 971M 126.5K
utoo-npm 7.01s 0.11s 11.12s 7.96s 995M 118.9K
utoo 6.92s 0.07s 11.65s 7.82s 953M 145.7K
PM vCtx iCtx netRX netTX cache node_mod lock
bun 17.1K 18.7K 1.19G 6M 1.86G 1.75G 1M
utoo-next 137.7K 92.4K 1.16G 5M 1.71G 1.70G 2M
utoo-npm 131.4K 96.0K 1.16G 5M 1.71G 1.70G 2M
utoo 116.7K 67.1K 1.16G 6M 1.71G 1.70G 2M

p1_resolve

PM wall ±σ user sys RSS pgMinor
bun 2.08s 0.04s 4.40s 0.81s 508M 177.9K
utoo-next 2.74s 0.07s 5.46s 1.22s 604M 86.1K
utoo-npm 2.91s 0.08s 5.65s 1.50s 613M 83.8K
utoo 2.32s 0.03s 6.31s 1.14s 638M 121.4K
PM vCtx iCtx netRX netTX cache node_mod lock
bun 9.7K 4.7K 202M 3M 107M - 1M
utoo-next 55.7K 73.4K 200M 2M 7M 3M 2M
utoo-npm 81.6K 93.2K 200M 2M 7M 3M 2M
utoo 18.1K 19.4K 202M 3M 7M 3M 2M

p3_cold_install

PM wall ±σ user sys RSS pgMinor
bun 5.81s 0.32s 5.87s 6.14s 643M 205.0K
utoo-next 5.30s 0.05s 4.93s 6.91s 500M 63.2K
utoo-npm 5.26s 0.03s 5.04s 6.92s 513M 62.5K
utoo 6.61s 3.10s 5.09s 6.99s 568M 61.0K
PM vCtx iCtx netRX netTX cache node_mod lock
bun 8.3K 6.8K 1019M 4M 1.76G 1.76G 1M
utoo-next 108.7K 53.5K 989M 3M 1.70G 1.70G 3M
utoo-npm 111.1K 53.8K 989M 3M 1.70G 1.70G 3M
utoo 135.5K 49.4K 990M 4M 1.70G 1.70G 3M

p4_warm_link

PM wall ±σ user sys RSS pgMinor
bun 2.17s 0.08s 0.15s 1.19s 135M 32.5K
utoo-next 1.90s 0.06s 0.52s 2.31s 79M 18.4K
utoo-npm 1.91s 0.03s 0.52s 2.33s 79M 18.6K
utoo 1.95s 0.27s 0.50s 2.33s 79M 18.2K
PM vCtx iCtx netRX netTX cache node_mod lock
bun 436 15 5M 13K 1.91G 1.75G 1M
utoo-next 43.2K 17.2K 4K 14K 1.70G 1.70G 2M
utoo-npm 43.4K 17.3K 1K 15K 1.70G 1.70G 2M
utoo 42.6K 17.2K 4K 8K 1.71G 1.70G 2M

npmmirror.com: no output captured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Pkg Manager Area: Package Manager benchmark Run pm-bench on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant