perf(pm): remove registry cache hook#3045
Draft
elrrrrrrr wants to merge 1 commit into
Draft
Conversation
fedab9c to
3a49840
Compare
ef1f15b to
3f47d7e
Compare
3f47d7e to
6f349ab
Compare
0b4c7d5 to
c12fd4c
Compare
6f349ab to
8b02fd5
Compare
c12fd4c to
fc7be5f
Compare
8b02fd5 to
ed9ee58
Compare
📊 pm-bench-phases ·
|
| PM | wall | ±σ | user | sys | RSS | pgMinor |
|---|---|---|---|---|---|---|
| bun | 7.12s | 0.23s | 10.45s | 6.13s | 667M | 295.9K |
| utoo-next | 7.17s | 0.37s | 10.83s | 7.86s | 971M | 126.5K |
| utoo-npm | 7.01s | 0.11s | 11.12s | 7.96s | 995M | 118.9K |
| utoo | 6.92s | 0.07s | 11.65s | 7.82s | 953M | 145.7K |
| PM | vCtx | iCtx | netRX | netTX | cache | node_mod | lock |
|---|---|---|---|---|---|---|---|
| bun | 17.1K | 18.7K | 1.19G | 6M | 1.86G | 1.75G | 1M |
| utoo-next | 137.7K | 92.4K | 1.16G | 5M | 1.71G | 1.70G | 2M |
| utoo-npm | 131.4K | 96.0K | 1.16G | 5M | 1.71G | 1.70G | 2M |
| utoo | 116.7K | 67.1K | 1.16G | 6M | 1.71G | 1.70G | 2M |
p1_resolve
| PM | wall | ±σ | user | sys | RSS | pgMinor |
|---|---|---|---|---|---|---|
| bun | 2.08s | 0.04s | 4.40s | 0.81s | 508M | 177.9K |
| utoo-next | 2.74s | 0.07s | 5.46s | 1.22s | 604M | 86.1K |
| utoo-npm | 2.91s | 0.08s | 5.65s | 1.50s | 613M | 83.8K |
| utoo | 2.32s | 0.03s | 6.31s | 1.14s | 638M | 121.4K |
| PM | vCtx | iCtx | netRX | netTX | cache | node_mod | lock |
|---|---|---|---|---|---|---|---|
| bun | 9.7K | 4.7K | 202M | 3M | 107M | - | 1M |
| utoo-next | 55.7K | 73.4K | 200M | 2M | 7M | 3M | 2M |
| utoo-npm | 81.6K | 93.2K | 200M | 2M | 7M | 3M | 2M |
| utoo | 18.1K | 19.4K | 202M | 3M | 7M | 3M | 2M |
p3_cold_install
| PM | wall | ±σ | user | sys | RSS | pgMinor |
|---|---|---|---|---|---|---|
| bun | 5.81s | 0.32s | 5.87s | 6.14s | 643M | 205.0K |
| utoo-next | 5.30s | 0.05s | 4.93s | 6.91s | 500M | 63.2K |
| utoo-npm | 5.26s | 0.03s | 5.04s | 6.92s | 513M | 62.5K |
| utoo | 6.61s | 3.10s | 5.09s | 6.99s | 568M | 61.0K |
| PM | vCtx | iCtx | netRX | netTX | cache | node_mod | lock |
|---|---|---|---|---|---|---|---|
| bun | 8.3K | 6.8K | 1019M | 4M | 1.76G | 1.76G | 1M |
| utoo-next | 108.7K | 53.5K | 989M | 3M | 1.70G | 1.70G | 3M |
| utoo-npm | 111.1K | 53.8K | 989M | 3M | 1.70G | 1.70G | 3M |
| utoo | 135.5K | 49.4K | 990M | 4M | 1.70G | 1.70G | 3M |
p4_warm_link
| PM | wall | ±σ | user | sys | RSS | pgMinor |
|---|---|---|---|---|---|---|
| bun | 2.17s | 0.08s | 0.15s | 1.19s | 135M | 32.5K |
| utoo-next | 1.90s | 0.06s | 0.52s | 2.31s | 79M | 18.4K |
| utoo-npm | 1.91s | 0.03s | 0.52s | 2.33s | 79M | 18.6K |
| utoo | 1.95s | 0.27s | 0.50s | 2.33s | 79M | 18.2K |
| PM | vCtx | iCtx | netRX | netTX | cache | node_mod | lock |
|---|---|---|---|---|---|---|---|
| bun | 436 | 15 | 5M | 13K | 1.91G | 1.75G | 1M |
| utoo-next | 43.2K | 17.2K | 4K | 14K | 1.70G | 1.70G | 2M |
| utoo-npm | 43.4K | 17.3K | 1K | 15K | 1.70G | 1.70G | 2M |
| utoo | 42.6K | 17.2K | 4K | 8K | 1.71G | 1.70G | 2M |
npmmirror.com: no output captured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegistryClient::cache_version_manifestpreload hookUnifiedRegistryimplementation of that hookValidation
cargo fmtcargo check -p utoo-ruboristcargo test -p utoo-ruborist mock_registry_executes_manifest_provider_jobs -- --nocapturecargo test -p utoo-ruborist test_unified_registry_executes_extract_manifest_provider_job -- --nocapturecargo clippy --all-targets -- -D warnings --no-depsSplit Plan
Part of the resolver stack split from source PR #3028. This removes a preload-era cache callback before the registry memory-cache cleanup.