perf(pm): remove resolver memory cache layer#3047
Draft
elrrrrrrr wants to merge 1 commit into
Draft
Conversation
elrrrrrrr
added
A-Pkg Manager
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the global MemoryCache singleton and its associated structures, including MemoryCacheInner, CacheStats, and the PackageCache type alias. The responsibility for managing in-memory manifest maps is shifted to the resolver's demand BFS loop for the duration of a resolution run, and documentation across the service and model modules has been updated to reflect this architectural change. I have no feedback to provide as there were no review comments to assess.
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-registry-stateless
branch
from
e77fe0b to
a1e1d86
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-remove-memory-cache
branch
from
f029690 to
0225a9c
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-remove-memory-cache
branch
from
0225a9c to
83396aa
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-registry-stateless
branch
2 times, most recently
from
2d30f46 to
bdd2790
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-remove-memory-cache
branch
from
83396aa to
8962d83
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-remove-memory-cache
branch
from
8962d83 to
4da37f1
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-registry-stateless
branch
from
bdd2790 to
44add1d
Compare
📊 pm-bench-phases ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemoryCache,PackageCache, and cache stats from ruborist service cacheValidation
cargo fmtcargo check -p utoo-ruboristcargo test -p utoo-ruborist service::registry::tests -- --nocapturecargo test -p utoo-ruborist service::api::tests::test_build_deps_options_creation -- --nocapturecargo clippy --all-targets -- -D warnings --no-depsSplit Plan
Part of the resolver stack split from source PR #3028. This follows the stateless registry cleanup after resolver-owned manifest state has replaced the global memory cache.