Use SheafDisplay fr composed sheaf view in discuss

lib/vyasa/sangh.ex

@@ -490,10 +490,8 @@ defmodule Vyasa.Sangh do
 
   # way number 3 -- no assoced parent (i.e. will be root sheaf), nothing to reconcile
   def make_reply(
-        %Sheaf{
-          parent_id: nil
-        } = reply,
-        attrs
+        %Sheaf{} = reply,
+        %{parent: nil} = attrs
       ) do
     IO.puts("CHECKPOINT Make Reply way 3 -- no parent to associate to")
     reply |> update_sheaf(attrs)

lib/vyasa_web/components/contexts/discuss.ex

@@ -668,6 +668,22 @@ defmodule VyasaWeb.Context.Discuss do
     }
   end
 
+  def handle_event(
+        "sheaf::clear_reply_to_context",
+        _,
+        %Socket{
+          assigns: %{
+            session: %{sangh: %{id: _sangh_id}},
+            draft_reflector_path: %Ltree{},
+            reply_to_path: _
+          }
+        } = socket
+      ) do
+    {:noreply,
+     socket
+     |> assign(reply_to_path: nil)}
+  end
+
   @impl true
   # TODO @ks0m1c another place that would require binding / permalinking apis
   # equivalent handler for the read mode as well...
@@ -700,7 +716,7 @@ defmodule VyasaWeb.Context.Discuss do
         "sheaf::publish",
         %{
           "body" => body
-        } = params,
+        } = _params,
         %Socket{
           assigns: %{
             session: %VyasaWeb.Session{
@@ -712,19 +728,15 @@ defmodule VyasaWeb.Context.Discuss do
             draft_reflector_path: %Ltree{
               labels: draft_sheaf_lattice_key
             },
-            reply_to_path: %Ltree{
-              labels: reply_to_lattice_key
-            },
+            reply_to_path: reply_to_path,
             sheaf_lattice: %{} = sheaf_lattice,
             sheaf_ui_lattice: %{} = sheaf_ui_lattice
           }
         } = socket
       )
       when is_binary(body) do
-    # TODO: the reply_to_lattice_key might be nil, that case of "create new thread" is not handled right now by discuss
-    reply_to_sheaf = sheaf_lattice[reply_to_lattice_key]
+    reply_to_sheaf = reply_to_path && sheaf_lattice[reply_to_path.labels]
     draft_sheaf = sheaf_lattice[draft_sheaf_lattice_key]
-    dbg()
 
     payload_precursor = %{
       body: body,
@@ -736,10 +748,10 @@ defmodule VyasaWeb.Context.Discuss do
     update_payload =
       case(is_nil(reply_to_sheaf)) do
         true ->
-          payload_precursor
+          payload_precursor |> Map.put(:parent, nil)
 
         false ->
-          Map.put(payload_precursor, :parent, reply_to_sheaf)
+          payload_precursor |> Map.put(:parent, reply_to_sheaf)
       end
 
     {:ok, updated_sheaf} = draft_sheaf |> Vyasa.Sangh.make_reply(update_payload)
@@ -788,11 +800,14 @@ defmodule VyasaWeb.Context.Discuss do
     {:noreply, socket}
   end
 
+  # FIXME: we need to improve how the modal show and hide is happening by calling the necessary
+  # JS-struct based functions, this is what is causing the scrolling bugs
   def handle_event(
         "navigate::see_discussion",
         _,
         socket
       ) do
+    IO.inspect("CHECKPOINT: the discuss context is reached")
     send(self(), "ui::toggle_show_sheaf_modal?")
     # target_path =
     #   curr_path

lib/vyasa_web/components/contexts/read.ex

@@ -834,18 +834,19 @@ defmodule VyasaWeb.Context.Read do
       inserted_at: Utils.Time.get_utc_now()
     }
 
+    # FIXME: the socket state should be the SOT. So even if the draft sheaf has an associated parent,
+    # when my reply_to_sheaf is nil, then the parent should be set to nil if it gets published.
+    # currently this is NOT happening.
     reply_payload =
       case reply_to_sheaf do
         %Sheaf{} ->
           payload_precursor |> Map.put(:parent, reply_to_sheaf)
 
         nil ->
-          payload_precursor
+          # so the socket's reply_to will take priority, even if the draft sheaf may already an associated parent, this will take priority.
+          payload_precursor |> Map.put(:parent, nil)
       end
 
-    dbg()
-    # FIXME: not sure why this is broken lol, just revisit the publishing routine properly
-
     draft_sheaf
     |> Vyasa.Sangh.make_reply(reply_payload)
 
@@ -857,6 +858,25 @@ defmodule VyasaWeb.Context.Read do
      |> cascade_stream_change()}
   end
 
+  def handle_event(
+        "sheaf::clear_reply_to_context",
+        _,
+        %Socket{
+          assigns: %{
+            draft_reflector: %Sheaf{} = _draft_sheaf,
+            draft_reflector_ui: %SheafUiState{
+              marks_ui: %MarksUiState{} = _ui_state
+            },
+            reply_to: _reply_to_sheaf
+          }
+        } = socket
+      ) do
+    {:noreply,
+     socket
+     |> assign(reply_to: nil)
+     |> cascade_stream_change()}
+  end
+
   @impl true
   # TODO @ks0m1c this is an example of what binding/permalinking should handle
   # we need to do a push-patch direction from this function
@@ -909,7 +929,7 @@ defmodule VyasaWeb.Context.Read do
   # TODO: sheaf-crud: reply_to is currently set to the same as the active_sheaf
   def render(assigns) do
     ~H"""
-    <div id={@id} class="flex-grow" >
+    <div id={@id} class="flex-grow">
       <!-- CONTENT DISPLAY: -->
       <div id="content-display" class="mx-auto max-w-2xl">
         <%= if @content_action == :show_sources do %>