Name the callee zero test cannot execute in test failures - #429
Open
guygrigsby wants to merge 1 commit into
Open
Name the callee zero test cannot execute in test failures#429guygrigsby wants to merge 1 commit into
guygrigsby wants to merge 1 commit into
Conversation
Both test interpreters failed with only the test label appended, e.g. "zero test unknown function: my test", which reads as a broken label and hides the actual missing function. Thread the callee name and call node into test_eval_function and pgt_eval_function so the existing null-function guard reports what failed and where: zero test unknown function 'myHelper': my test std.* callees outside std.testing get not-implemented framing instead, matching the runner's existing unsupported wording, since those are real stdlib functions the test interpreters do not execute: zero graph test runner does not implement 'std.mem.span' yet; ... Update the stale testing skill guidance that misread this failure as a malformed test label, add a command contract pinning the message and location, and adjust two file line budgets.
|
@guygrigsby is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
zero testfailures name the callee the runner could not execute instead of appending only the test label. Addresses the diagnostic confusion in #428; the underlying limitation (the test interpreters execute onlystd.testinghelpers and pure zerolang functions) is unchanged.Before:
After, for a callee that does not resolve:
After, for a real stdlib function the runner does not execute, matching the existing unsupported-construct wording:
Changes:
test_eval_functionandpgt_eval_functionso the existing null-function guard is the single place the message is produced, in both interpreters. Failures now anchor to the unresolved call's location instead of the test function's.std.-prefixed callees get the not-implemented framing; other unresolved names keepunknown function '<name>'.skill-data/testing.mdparagraph that read this failure as a malformed test label and advised deleting the test; regeneratedembedded_skills.incis included.failure.sourceFilefor a package test reachingstd.mem.*, and adjust two file line budgets inscripts/compiler-metrics.mts.Verified locally on darwin-arm64:
make -C native/zero-c,pnpm run command-contracts:local,pnpm run conformance:local,pnpm run native:test:local,pnpm run native:sanitize,pnpm run workspace:checksall pass. The:sandboxvariants were not run locally (they requireVERCEL_OIDC_TOKEN); CI covers those paths.