Improve dynamic tree for movement#3463
Open
Gamemechanicwow wants to merge 5 commits into
Open
Conversation
Contributor
Contributor
|
yes, it should |
Contributor
|
i have tested the following dungeons yesterday, this pr performed well in: btw hunter&warlock's pets got stuck no more. |
Reverts part of commit 7ae72b3 and follow ups
parameter forwarding
based on documentation /// If the hit parameter is zero, then the start position is on the wall that /// was hit and the value of @p hitNormal is undefined. /// /// If 0 < t < 1.0 then the following applies: /// /// @code /// distanceToHitBorder = distanceToEndPosition * t /// hitPoint = startPos + (endPos - startPos) * t /// @Endcode
this matches code used for blink
Gamemechanicwow
force-pushed
the
fix-dyn-tree-for-movement
branch
from
3f56060 to
9efd1bd
Compare
Contributor
Author
|
PR is now ready for review. |
Contributor
|
Have you tested blinking through doors to make sure you didn't break that? It shouldn't be possible to blink through a door no matter the angle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Implemented a new parameter to be passed down to the BIH tree.
stopAtFirst = true -- used for LOS, we are only interested in if a hit occurs
stopAtFirst = false -- used for Pathing, we are interested in the closest hit
Reverts
fdefcaf
-> and follow up commit -> ad73645
also reverses parts of 7ae72b3 and its follow up commits, as that check is no longer needed.
PathInfo::CutPathWithDynamicLoS()
now checks slightly above ground, this matches the code in Map::GetWalkHitPosition
Map::GetWalkHitPosition - mmap related
Hitnormal logic changed to match documentation. this includes an early return
FollowMovementGenerator
This has no dyn tree check. I assume its intended
WIP
I am marking this PR as draft - i have yet to do some largescale testing.
Proof
Issues
How2Test
Todo / Checklist