Implement port for STM32WBA. Bump wolfHAL lib to latest#799
Conversation
c482793 to
5efcf98
Compare
5efcf98 to
660a4fa
Compare
dgarske
left a comment
There was a problem hiding this comment.
Skoll Multi-Scan Review
Modes: review + review-securityOverall recommendation: COMMENT
Findings: 5 total — 5 posted, 0 skipped
4 finding(s) posted as inline comments (see file-level comments below)
1 finding(s) not tied to a diff line (full detail below)
Posted findings
- [Medium] [review] DEBUG_UART path (GPIO/UART config macros + drivers) is never built in CI —
hal/boards/stm32wba55cg_nucleo/board.mk:28-31 - [Low] [review+review-security] Documented PLL1 configuration / divider comment does not arithmetically yield the stated 100 MHz SYSCLK —
hal/boards/stm32wba55cg_nucleo/board.c:69-93 - [Info] [review-security] New config disables the MPU (NO_MPU=1), reducing defense-in-depth —
config/examples/stm32wba.config:13 - [Info] [review-security] C99 mid-block for-loop declarations deviate from wolfSSL C89 style —
hal/boards/stm32wba55cg_nucleo/board.c:111,126
Findings not tied to a diff line
Non-ASCII (em-dash U+2014) characters introduced in new source files
File: hal/boards/stm32wba55cg_nucleo/board.c:7,35; hal/boards/stm32wba55cg_nucleo/board.h:70,80,106; hal/boards/stm32wba55cg_nucleo/board.mk:13,22
Function: (file-level comments)
Severity: Low
Category: convention
Both reviewers independently flagged that the new board files introduce U+2014 em-dash characters (-) in comments instead of 7-bit ASCII (7 newly-added lines across board.c, board.h, and board.mk, e.g. board.c:35 '/* Flash clock gate -- enabled before raising the wait-state count. */'). wolfBoot/wolfSSL source follows an ASCII-only convention. This compiles cleanly so it is non-blocking, but the non-ASCII bytes can confuse editors/diff tooling and violate project style. Note: the already-merged sibling stm32wb_nucleo files use the same em-dash style, so there is local precedent; this PR still adds new non-ASCII bytes.
Recommendation: Replace all em-dash (U+2014) occurrences with the ASCII hyphen '-' in the new board.c, board.h, and board.mk. Optionally clean up the sibling stm32wb_nucleo files in a separate pass.
Review generated by Skoll
Add STM32WBA55CG Nucleo port (wolfHAL backend)
Adds a wolfBoot port for the STM32WBA55CG Nucleo (Cortex-M33) on the wolfHAL backend, and bumps lib/wolfHAL to the latest.
Changes
Test plan