wc_port: guard fcntl behind WOLFSSL_KERNEL_MODE.#10521
Open
philljj wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the platform guards around the close-on-exec helper APIs so that userspace-only fcntl-based code is excluded for all kernel-mode builds (via WOLFSSL_KERNEL_MODE), not just Linux kernel module builds (WOLFSSL_LINUXKM).
Changes:
- Switch
wc_set_cloexec/wc_*_cloexecdeclarations inwc_port.hto be gated by!defined(WOLFSSL_KERNEL_MODE). - Switch the corresponding
fcntl.hinclude and implementations inwc_port.cto be gated by!defined(WOLFSSL_KERNEL_MODE).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wolfssl/wolfcrypt/wc_port.h | Updates the userspace-only guard for close-on-exec helper declarations to use WOLFSSL_KERNEL_MODE. |
| wolfcrypt/src/wc_port.c | Updates the userspace-only guard for fcntl-based close-on-exec helper implementations to use WOLFSSL_KERNEL_MODE. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Guard userspace filesystem code with
!defined(WOLFSSL_KERNEL_MODE)instead of!defined(WOLFSSL_LINUXKM).