Fix Nested Map Column Type Parsing Bug - #336
Open
ehddnr301 wants to merge 2 commits into
Open
Conversation
- Resolved xzkostyan#269 by ensuring the parser now tracks bracket levels and splits types accordingly.
Author
|
Hello, I just wanted to kindly follow up on my pull request #336. Please let me know if there's anything I can clarify or improve. Thanks for your time! |
|
Is this likely to ever be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@xzkostyan
Hello! It's my first pull request.
I want to fix bug for Nested Map columns.
I'm currently using a datahub, and I think modifying the code will make the column types visible
Please feel free to review the changes and provide any feedback or suggestions for improvement.
related datahub issue is datahub-project/datahub#9079
Test Table DDL
Before Edit

TypeError: Map.__init__() missing 1 required positional argument: 'value_type'After Edit

Checklist:
flake8and fix issues.pytestno tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.