Skip to content

unexport TSLNode.Node field and add SetLeft/SetRight methods - #48

Merged
yaacov merged 1 commit into
mainfrom
design-unexport-node
Jul 22, 2026
Merged

unexport TSLNode.Node field and add SetLeft/SetRight methods#48
yaacov merged 1 commit into
mainfrom
design-unexport-node

Conversation

@yaacov

@yaacov yaacov commented Jul 22, 2026

Copy link
Copy Markdown
Owner

The internal Node field is now unexported (node), enforcing use of the public API (Type, Value, Clone, SetLeft, SetRight) and preventing callers from bypassing encapsulation or corrupting internal state.

The internal Node field is now unexported (node), enforcing use of
the public API (Type, Value, Clone, SetLeft, SetRight) and preventing
callers from bypassing encapsulation or corrupting internal state.

Signed-off-by: yaacov <yzamir@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yaacov, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7eb0a4ff-787e-4470-82da-aed970e436dd

📥 Commits

Reviewing files that changed from the base of the PR and between da52251 and 3aa3e1b.

📒 Files selected for processing (2)
  • v6/pkg/tsl/tsl.go
  • v6/pkg/walkers/ident/walk.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch design-unexport-node

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yaacov
yaacov merged commit b84080e into main Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant