fix: update duration validation to use strfmt package#348
Open
nissy-dev wants to merge 1 commit into
Open
Conversation
nissy-dev
force-pushed
the
fix-duration-format
branch
from
44c6978 to
6c2258c
Compare
nissy-dev
commented
Dec 10, 2025
| func validateDuration(v any) error { | ||
| // Try validation with the Go duration format | ||
| if _, err := time.ParseDuration(v.(string)); err == nil { | ||
| if _, err := strfmt.ParseDuration(v.(string)); err == nil { |
Author
There was a problem hiding this comment.
I think it's more appropriate to use k8s APIServer's OpenAPI validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #347
I ran the tests locally and confirmed they passed without any issues.