try forever to get mirrors, slits into initial positions#19
Conversation
for more information, see https://pre-commit.ci
…o try-until-initial
for more information, see https://pre-commit.ci
ksunden
left a comment
ksunden
left a comment
There was a problem hiding this comment.
I'm still salty in general that this is necessary (empirically something does need to change here, just not happy that it's so), but not blocking on that front... just that it doesn't do what is intended yet
Regardless I am also unwilling to merge this particular kind of patch (complicated startup timing) without it being tested on the real hardware
|
I'm not a huge fan of unbounded startup loops... Perhaps we should issue a warning/error after a certain number of attempts (and or exponential backoff to give other factors which might be impeding success time to be fixed) |
|
@ddkohler @kameyer226 as end-users what behavior do you want? Do you want the mono to keep trying to return to the old positions forever? Do you want it to give up and shut itself off after a while? Do you want it to try a certain number of times and then just stop trying? |
|
I believe it should just try to move 3-4 times. The initialization already takes time, so adding a few trials makes little impact on overall time. |
|
@kameyer226 in your opinion what should happen if it doesn't succeed after 4 attempts? |
|
If not succeed, write failure to logger, not sure what else |
3 participants
closes #10
Untested, please look closely and test if you can.