fix: remove pkg_resources dependency broken by setuptools v82#1312
Open
themachinehf wants to merge 1 commit into
Open
fix: remove pkg_resources dependency broken by setuptools v82#1312themachinehf wants to merge 1 commit into
themachinehf wants to merge 1 commit into
Conversation
setuptools v82 removed pkg_resources which causes ModuleNotFoundError when importing concrete. Replace the legacy pkg_resources namespace declaration with implicit namespace packages (PEP 420) which require no special code in __init__.py. Fixes zama-ai#1308
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @themachinehf on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setuptools v82 (released Feb 2026) removed pkg_resources which causes ModuleNotFoundError when importing concrete.
Fix
Replace the legacy pkg_resources namespace declaration with implicit namespace packages (PEP 420) which require no special code in init.py.
Before:
with warnings.catch_warnings():
warnings.simplefilter("ignore")
import("pkg_resources").declare_namespace(name)
After:
# Implicit namespace packages (PEP 420) are used.
# No additional imports are needed.
Testing
Verified the fix resolves the import error. The implicit namespace package approach is the modern standard supported since Python 3.3.
Fixes #1308