Clean up Python dependency management #226
Conversation
This is a proper package which declares its dependencies, so this should not add value anymore. It likely was also outdated, or at least hard to maintain. The main use case of this was probably to catch incomplete postinstallation by the user when zkg was shipped as part of Zeek; since with zeek/zeek#5553 we do not do this anymore this is unneeded.
We already maintain dependencies in `pyproject.toml` which is supported by modern developer tooling and also RTD.
There really is no reason to make this conditional if we assume that users install zkg correctly. We also never declared an optional dependency on `argcomplete`.
bbannier
force-pushed
the
topic/bbannier/dependencies
branch
from
b0c0336 to
a43c23a
Compare
ckreibich
left a comment
ckreibich
left a comment
There was a problem hiding this comment.
Nice, I'm on board with all of these. The only thing I wonder about is the first commit, i.e. whether we should still keep an explanation for the needed dependencies if for some reason the installation is messed up or non-standard (say because the user wants to rely on system packages to provide them but something goes wrong — similar to my comment over on #228).
The help output could be more streamlined — a simple pointer to the docs perhaps — but would a bit more graceful than an unhandled ImportError.
I have never seen this anywhere else, and it seems weird. Unless looking at very simple scripts without any dependencies, I'd expect all Python projects to have some |
2 participants
No description provided.