Stop emitting [template] and [template_vars] sections in zkg.meta#227
Merged
Conversation
These sections were always informational, and we never implemented the functionality to update the instantiated template on template updates. It is unlikely that we will ever be able to reliably implement this with the current loosly defined template. The sections were also potentially confusing to whoever looked at them since they referred to the state at template instantiation, but never reflected subsequent edits. This commit drops them without replacement. Closes #220.
Member
Author
|
@ckreibich How does this look to you? It seems the half-feature we have ATM could be more confusing than useful, and I am not aware where what we have has ever helped use debug issues. |
ckreibich
approved these changes
Jul 2, 2026
ckreibich
left a comment
ckreibich
left a comment
Member
There was a problem hiding this comment.
Yeah, I'm on board. I think it's quite unlikely that we'll implement some sort of tooling based on this information at this point, and the version-use context is also in the initial commit generated by the templating. We should keep that one, and your PR doesn't change that.
We would previously record these in the generated `zkg.meta`, but stopped doing that. Keep a record of them in the initial Git commit where we also already record some information on the template.
We previously would only mention the name of the template in the initial commit, but not its URI. Since we dropped emitting the URI from `zkg.meta`, record it in the initial commit as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These sections were always informational, and we never implemented the functionality to update the instantiated template on template updates. It is unlikely that we will ever be able to reliably implement this with the current loosly defined template. The sections were also potentially confusing to whoever looked at them since they referred to the state at template instantiation, but never reflected subsequent edits.
This commit drops them without replacement.
Closes #220.