cluster_backend_zeromq: Set Cluster::Backend::ZeroMQ::ipv6=T when needed#101
Merged
Merged
Conversation
Now that Cluster::Backend::ZeroMQ::ipv6 defaults to false, ensure it is toggled to true if any of the node addresses resolves to an IPv6 address. Also, add brackets around IPv6 addresses for the ZeroMQ endpoints as otherwise ZeroMQ will consider the addresses as a device. Add a test for this, too. Relates to #5251
awelzel
force-pushed
the
topic/awelzel/5251-zeromq-ipv6-not-default
branch
from
26a3b1a to
064d057
Compare
timwoj
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Cluster::Backend::ZeroMQ::ipv6 defaults to false, ensure it is
toggled to true if any of the node addresses resolves to an IPv6 address.
Also, add brackets around IPv6 addresses for the ZeroMQ endpoints as otherwise
ZeroMQ will consider the addresses as a device. Add a test for this, too.
Relates to #5251