-
Notifications
You must be signed in to change notification settings - Fork 16
[WIP] feat: add shared io_uring context pool support #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CLiqing
wants to merge
18
commits into
zilliztech:master
Choose a base branch
from
CLiqing:feat/io-uring-context-pool
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
25698db
feat: add unified IO context pool backend
CLiqing 3da7d68
fix: restore IOReader eager submit semantics
CLiqing bf8a467
feat: add pollable io_uring completion reader
CLiqing 8e505b7
fix: report unavailable io_uring completion polling
CLiqing f13d06d
fix: always compile completion reader shim
CLiqing 704c1c2
fix: harden io_uring completion reader submission
CLiqing f1a5859
fix: make completion reader cleanup no-throw
CLiqing 9ae1d3c
fix: bound interrupted IO retries
CLiqing 6426d75
fix: harden io_uring reader failure handling
c41d628
fix: keep io_uring reader cleanup safe
847febf
fix: preserve io_uring completion requests
13ffeed
fix: harden io_uring backend lifecycle
0ad2d8e
fix: harden io context lifecycle
3a82c63
fix: harden io context pool lifecycle
f318c09
fix: cover io context failure cleanup
2d61dd5
fix: handle aio progress and null cqe
59317b3
fix: close io request lifecycle gaps
1c14b4e
fix: align legacy io api contracts
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C++20 standard is linked as
PUBLIC, meaning every target that depends on this library is forced to compile with C++20. This is driven bystd::spanusage in headers. Downstream projects that cannot adopt C++20 will fail to build. The requirement should bePRIVATE, andstd::span-using headers should be isolated or guarded.