Skip to content

[milvus] Add terminationGracePeriodSeconds to milvus components #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thbelmont wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[milvus] Add terminationGracePeriodSeconds to milvus components #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/milvus/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: milvus
appVersion: "2.6.3"
kubeVersion: "^1.10.0-0"
description: Milvus is an open-source vector database built to power AI applications and vector similarity search.
version: 5.0.5
version: 5.0.6
keywords:
- milvus
- elastic
Expand Down
7 changes: 6 additions & 1 deletion charts/milvus/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ The following table lists the configurable parameters of the Milvus Standalone c
| `standalone.persistence.persistentVolumeClaim.accessModes` | The Milvus standalone data Persistence access modes | `ReadWriteOnce` |
| `standalone.persistence.persistentVolumeClaim.size` | The size of Milvus standalone data Persistent Volume Storage Class | `5Gi` |
| `standalone.persistence.persistentVolumeClaim.subPath` | SubPath for Milvus standalone data mount | `unset` |
| `standalone.terminationGracePeriodSeconds` | Deployment terminationGracePeriodSeconds | `` |

### Milvus Proxy Deployment Configuration

Expand All @@ -452,6 +453,7 @@ The following table lists the configurable parameters of the Milvus Proxy compon
| `proxy.http.debugMode.enabled` | Enable debug mode for rest api | `false` |
| `proxy.tls.enabled` | Enable porxy tls connection | `false` |
| `proxy.strategy` | Deployment strategy configuration | RollingUpdate |
| `proxy.terminationGracePeriodSeconds` | Deployment terminationGracePeriodSeconds | `` |
| `proxy.annotations` | Additional pod annotations | `{}` |
| `proxy.hpa` | Enable hpa for proxy node | false |
| `proxy.minReplicas` | Specify the minimum number of replicas | 1 |
Expand All @@ -477,6 +479,7 @@ The following table lists the configurable parameters of the Milvus Query Node c
| `queryNode.profiling.enabled` | Whether to enable live profiling | `false` |
| `queryNode.extraEnv` | Additional Milvus Query Node container environment variables | `[]` |
| `queryNode.strategy` | Deployment strategy configuration | RollingUpdate |
| `queryNode.terminationGracePeriodSeconds` | Deployment terminationGracePeriodSeconds | `` |
| `queryNode.annotations` | Additional pod annotations | `{}` |
| `queryNode.hpa` | Enable hpa for query node | false |
| `queryNode.minReplicas` | Specify the minimum number of replicas | 1 |
Expand Down Expand Up @@ -504,6 +507,7 @@ The following table lists the configurable parameters of the Milvus Data Node co
| `dataNode.profiling.enabled` | Whether to enable live profiling | `false` |
| `dataNode.extraEnv` | Additional Milvus Data Node container environment variables | `[]` |
| `dataNode.strategy` | Deployment strategy configuration | RollingUpdate |
| `dataNode.terminationGracePeriodSeconds` | Deployment terminationGracePeriodSeconds | `` |
| `dataNode.annotations` | Additional pod annotations | `{}` |
| `dataNode.hpa` | Enable hpa for data node | false |
| `dataNode.minReplicas` | Specify the minimum number of replicas | 1 |
Expand Down Expand Up @@ -534,6 +538,7 @@ The following table lists the configurable parameters of the Milvus Mix Coordina
| `mixCoordinator.service.loadBalancerSourceRanges` | List of IP CIDRs allowed access to lb (if supported) | `[]` |
| `mixCoordinator.service.externalIPs` | Service external IP addresses | `[]` |
| `mixCoordinator.strategy` | Deployment strategy configuration | RollingUpdate |
| `mixCoordinator.terminationGracePeriodSeconds` | Deployment terminationGracePeriodSeconds | `` |
| `mixCoordinator.annotations` | Additional pod annotations | `{}` |

### Milvus Streaming Node Deployment Configuration
Expand All @@ -554,7 +559,7 @@ The following table lists the configurable parameters of the Milvus Streaming No
| `streamingNode.profiling.enabled` | Whether to enable live profiling | `false` |
| `streamingNode.extraEnv` | Additional Milvus Streaming Node container environment variables | `[]` |
| `streamingNode.strategy` | Deployment strategy configuration | `{}` |

| `streamingNode.terminationGracePeriodSeconds` | Deployment terminationGracePeriodSeconds | `` |

### TEI Configuration

Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/attu-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,10 @@ spec:
securityContext:
{{ toYaml .Values.attu.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.attu.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.attu.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.attu.terminationGracePeriodSeconds }}
{{- end }}
{{- end }}
7 changes: 6 additions & 1 deletion charts/milvus/templates/datacoord-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,12 @@ spec:
securityContext:
{{ toYaml .Values.dataCoordinator.securityContext | indent 8 }}
{{- end }}

{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.dataCoordinator.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.dataCoordinator.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.dataCoordinator.terminationGracePeriodSeconds }}
{{- end }}
volumes:
- name: milvus-config
configMap:
Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/datanode-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,12 @@ spec:
{{- if .Values.dataNode.securityContext }}
securityContext:
{{ toYaml .Values.dataNode.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.dataNode.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.dataNode.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.dataNode.terminationGracePeriodSeconds }}
{{- end }}
volumes:
- name: milvus-config
Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/indexcoord-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,12 @@ spec:
{{- if .Values.indexCoordinator.securityContext }}
securityContext:
{{ toYaml .Values.indexCoordinator.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.indexCoordinator.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.indexCoordinator.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.indexCoordinator.terminationGracePeriodSeconds }}
{{- end }}

volumes:
Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/indexnode-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,12 @@ spec:
{{- if .Values.indexNode.securityContext }}
securityContext:
{{ toYaml .Values.indexNode.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.indexNode.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.indexNode.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.indexNode.terminationGracePeriodSeconds }}
{{- end }}

volumes:
Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/mixcoord-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,12 @@ spec:
{{- if .Values.mixCoordinator.securityContext }}
securityContext:
{{ toYaml .Values.mixCoordinator.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.mixCoordinator.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.mixCoordinator.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.mixCoordinator.terminationGracePeriodSeconds }}
{{- end }}

volumes:
Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/proxy-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,12 @@ spec:
{{- if .Values.proxy.securityContext }}
securityContext:
{{ toYaml .Values.proxy.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.proxy.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.proxy.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.proxy.terminationGracePeriodSeconds }}
{{- end }}

volumes:
Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/querycoord-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,12 @@ spec:
{{- if .Values.queryCoordinator.securityContext }}
securityContext:
{{ toYaml .Values.queryCoordinator.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.queryCoordinator.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.queryCoordinator.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.queryCoordinator.terminationGracePeriodSeconds }}
{{- end }}

volumes:
Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/querynode-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ spec:
{{- if .Values.queryNode.securityContext }}
securityContext:
{{ toYaml .Values.queryNode.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.queryNode.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.queryNode.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.queryNode.terminationGracePeriodSeconds }}
{{- end }}

volumes:
Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/rootcoord-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,12 @@ spec:
{{- if .Values.rootCoordinator.securityContext }}
securityContext:
{{ toYaml .Values.rootCoordinator.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.rootCoordinator.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.rootCoordinator.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.rootCoordinator.terminationGracePeriodSeconds }}
{{- end }}

volumes:
Expand Down
6 changes: 6 additions & 0 deletions charts/milvus/templates/standalone-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,12 @@ spec:
{{- if .Values.standalone.securityContext }}
securityContext:
{{ toYaml .Values.standalone.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.standalone.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.standalone.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.standalone.terminationGracePeriodSeconds }}
{{- end }}

volumes:
Expand Down
7 changes: 7 additions & 0 deletions charts/milvus/templates/streamingnode-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,13 @@ spec:
securityContext:
{{ toYaml .Values.streamingNode.securityContext | indent 8 }}
{{- end }}
{{- if and (.Values.terminationGracePeriodSeconds) (not .Values.streamingNode.terminationGracePeriodSeconds) }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- if .Values.streamingNode.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.streamingNode.terminationGracePeriodSeconds }}
{{- end }}

volumes:
- name: milvus-config
configMap:
Expand Down
18 changes: 18 additions & 0 deletions charts/milvus/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ securityContext: {}
# fsGroup: 1000
# runAsNonRoot: true

# Global terminationGracePeriodSeconds
# If set, this will apply to all milvus components
# Individual components can be set to a different terminationGracePeriodSeconds
# ref: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination-flow
terminationGracePeriodSeconds: ""

# Global topologySpreadConstraints
# If set, this will apply to all milvus components
# Individual components can be set to different topologySpreadConstraints
Expand Down Expand Up @@ -235,6 +241,7 @@ standalone:
securityContext: {}
containerSecurityContext: {}
topologySpreadConstraints: [] # Component specific topologySpreadConstraints
terminationGracePeriodSeconds: ""
extraEnv: []
heaptrack:
enabled: false
Expand Down Expand Up @@ -308,6 +315,7 @@ proxy:
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}
terminationGracePeriodSeconds: ""
annotations: {}
hpa:
enabled: false
Expand Down Expand Up @@ -336,6 +344,7 @@ rootCoordinator:
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}
terminationGracePeriodSeconds: ""
annotations: {}

service:
Expand Down Expand Up @@ -365,6 +374,7 @@ queryCoordinator:
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}
terminationGracePeriodSeconds: ""
annotations: {}

service:
Expand Down Expand Up @@ -402,6 +412,7 @@ queryNode:
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}
terminationGracePeriodSeconds: ""
annotations: {}
hpa:
enabled: false
Expand Down Expand Up @@ -431,6 +442,7 @@ indexCoordinator:
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}
terminationGracePeriodSeconds: ""
annotations: {}

service:
Expand Down Expand Up @@ -467,6 +479,7 @@ indexNode:
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}
terminationGracePeriodSeconds: ""
annotations: {}
hpa:
enabled: false
Expand Down Expand Up @@ -495,6 +508,7 @@ dataCoordinator:
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}
terminationGracePeriodSeconds: ""
annotations: {}

service:
Expand Down Expand Up @@ -522,6 +536,7 @@ dataNode:
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}
terminationGracePeriodSeconds: ""
annotations: {}
hpa:
enabled: false
Expand Down Expand Up @@ -552,6 +567,7 @@ mixCoordinator:
# Deployment strategy, default is RollingUpdate
# Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-update-deployment
strategy: {}
terminationGracePeriodSeconds: ""
annotations: {}

service:
Expand All @@ -573,6 +589,7 @@ streamingNode:
profiling:
enabled: false # Enable live profiling
strategy: {}
terminationGracePeriodSeconds: ""

attu:
enabled: false
Expand All @@ -590,6 +607,7 @@ attu:
resources: {}
securityContext: {}
containerSecurityContext: {}
terminationGracePeriodSeconds: ""
podLabels: {}
annotations: {}
ingress:
Expand Down
Loading