Skip to content

feat #296: Pass S3 access keys from existent secret #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gcrm3 wants to merge 38 commits into
base: master
Choose a base branch
from
Open

feat #296: Pass S3 access keys from existent secret #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
161ca37
add container security contex to all containers and init containers
May 20, 2025
88f7309
update tei readme (#219)
zhuwenxing May 28, 2025
ff31f24
use tei chart instead of built-in templates (#200)
haorenfsa May 29, 2025
94eb7ff
release tag 2.5.13 (#224)
zhikunyao Jun 9, 2025
387067a
[milvus] - Add OpenShift route support for Attu UI (#226)
ckavili Jun 25, 2025
c429ef7
update kafka-exporter image (#228)
zhikunyao Jun 27, 2025
c318ce2
update minio version (#230)
zhikunyao Jun 27, 2025
743ca16
release tag 2.5.14 (#231)
zhikunyao Jun 28, 2025
d481176
update minio version (#232)
zhikunyao Jul 2, 2025
77fd055
fixes #220: Adds runtimeClassName option to query and index deploymen…
qpehedm Jul 2, 2025
6b1457c
release tag 2.5.15 (#237)
zhikunyao Jul 19, 2025
f7189d8
release tag 2.5.16 (#239)
zhikunyao Aug 5, 2025
c086bc1
release tag 2.6.0 and update minio (#242)
zhikunyao Aug 6, 2025
7bd630c
update bitnami image to use legacy bitnami repo (#244)
AlintaLu Aug 29, 2025
8d2159e
release tag 2.6.1 (#246)
zhikunyao Sep 1, 2025
4f4f49f
Release tag 2.6.2 (#249)
zhikunyao Sep 18, 2025
4606db0
release tag 2.6.3 (#255)
zhikunyao Oct 1, 2025
3de58b7
Upgrade etcd chart to v8.12.0 and update config (#258)
Oct 20, 2025
715b935
release tag 2.6.4 (#261)
zhikunyao Oct 21, 2025
45f03ee
release tag 2.6.5 (#263)
zhikunyao Nov 10, 2025
ca6e714
feat: add woodpecker component (#254)
yellow-shine Nov 10, 2025
5e0cc8e
feat(milvus): add cdc component (#264)
AlintaLu Nov 12, 2025
1912d70
release tag 2.6.6 (#266)
zhikunyao Nov 21, 2025
fc6a384
upgrade etcd, bump version (#267)
AlintaLu Nov 27, 2025
31ff951
release tag 2.6.7 (#269)
zhikunyao Dec 4, 2025
507009f
release tag 2.6.8 (#272)
zhikunyao Jan 1, 2026
355e78d
release tag 2.6.9 (#277)
zhikunyao Jan 16, 2026
bf753af
release tag 2.6.10 (#279)
zhikunyao Jan 30, 2026
2ec81d4
release tag 2.6.11 (#280)
zhikunyao Feb 12, 2026
4285510
release tag 2.6.12 (#281)
zhikunyao Mar 11, 2026
da3e0a9
release tag 2.6.13 (#282)
zhikunyao Mar 22, 2026
8968b0a
enhance: support replica resource group isolation in cluster mode (#283)
chyezh Apr 3, 2026
3f42c00
release tag 2.6.14 (#284)
zhikunyao Apr 7, 2026
ba72485
release tag 2.6.15 (#288)
zhikunyao Apr 16, 2026
ed8ac74
release tag 2.6.16 (#292)
zhikunyao May 13, 2026
8617ffe
release tag 2.6.17 (#293)
zhikunyao May 17, 2026
baf5122
S3 keys from a secret and custom cert path
May 28, 2026
dfdafb1
Merge branch 'master' into master
gcrm3 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions charts/milvus/templates/config.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,13 @@ minio:
{{- if .Values.externalS3.enabled }}
address: {{ .Values.externalS3.host }}
port: {{ .Values.externalS3.port }}
{{- if not .Values.keysFromSecret.enabled}}
accessKeyID: {{ .Values.externalS3.accessKey }}
secretAccessKey: {{ .Values.externalS3.secretKey }}
{{- end}}
{{- if .Values.externalS3.tlsCACert}}
ssl.tlsCACert: {{ .Values.externalS3.tlsCACert }} ## custom path to certs file
{{- end}}
useSSL: {{ .Values.externalS3.useSSL }}
bucketName: {{ .Values.externalS3.bucketName }}
rootPath: {{ .Values.externalS3.rootPath }}
Expand Down
12 changes: 12 additions & 0 deletions charts/milvus/templates/datanode-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,18 @@ spec:
- name: LD_LIBRARY_PATH
value: /milvus/tools/heaptrack/lib:/milvus/lib:/usr/lib
{{- end }}
{{- if .Values.externalS3.keysFromSecret.enabled }}
- name: MINIO_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_accessKey
- name: MINIO_SECRET_ACCESS_KEY
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_secretKey
{{- end }}
{{- if .Values.dataNode.extraEnv }}
{{- toYaml .Values.dataNode.extraEnv | nindent 8 }}
{{- end }}
Expand Down
12 changes: 12 additions & 0 deletions charts/milvus/templates/indexnode-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,18 @@ spec:
divisor: 1Gi
resource: limits.ephemeral-storage
{{- end }}
{{- if .Values.externalS3.keysFromSecret.enabled }}
- name: MINIO_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_accessKey
- name: MINIO_SECRET_ACCESS_KEY
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_secretKey
{{- end }}
{{- if .Values.indexNode.extraEnv }}
{{- toYaml .Values.indexNode.extraEnv | nindent 8 }}
{{- end }}
Expand Down
12 changes: 12 additions & 0 deletions charts/milvus/templates/querynode-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,18 @@ spec:
- name: MILVUS_SERVER_LABEL_RESOURCE_GROUP
value: {{ .rg | quote }}
{{- end }}
{{- if .Values.externalS3.keysFromSecret.enabled }}
- name: MINIO_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_accessKey
- name: MINIO_SECRET_ACCESS_KEY
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_secretKey
{{- end }}
{{- if .Values.queryNode.extraEnv }}
{{- toYaml .Values.queryNode.extraEnv | nindent 8 }}
{{- end }}
Expand Down
12 changes: 12 additions & 0 deletions charts/milvus/templates/standalone-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,18 @@ spec:
divisor: 1Gi
resource: limits.ephemeral-storage
{{- end }}
{{- if .Values.externalS3.keysFromSecret.enabled }}
- name: MINIO_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_accessKey
- name: MINIO_SECRET_ACCESS_KEY
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_secretKey
{{- end }}
{{- if .Values.standalone.extraEnv }}
{{- toYaml .Values.standalone.extraEnv | nindent 8 }}
{{- end }}
Expand Down
12 changes: 12 additions & 0 deletions charts/milvus/templates/streamingnode-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,18 @@ spec:
- name: MILVUS_SERVER_LABEL_RESOURCE_GROUP
value: {{ .rg | quote }}
{{- end }}
{{- if .Values.externalS3.keysFromSecret.enabled }}
- name: MINIO_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_accessKey
- name: MINIO_SECRET_ACCESS_KEY
valueFrom:
secretKeyRef:
name: {{ .Values.externalS3.loadKeysFromSecret.secretName }}
key: s3_secretKey
{{- end }}
{{- if .Values.streamingNode.extraEnv }}
{{- toYaml .Values.streamingNode.extraEnv | nindent 8 }}
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions charts/milvus/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1385,6 +1385,9 @@ externalS3:
enabled: false
host: ""
port: ""
keysFromSecret: #load accesskey and secret key from a secret
enabled: false
secret_name: ""
accessKey: ""
secretKey: ""
useSSL: false
Expand Down
Loading