[backport core/1.44] fix: remove failed to export toast when cancelling export workflow - #12422
Closed
comfy-pr-bot wants to merge 1 commit into
Closed
[backport core/1.44] fix: remove failed to export toast when cancelling export workflow#12422comfy-pr-bot wants to merge 1 commit into
comfy-pr-bot wants to merge 1 commit into
Conversation
…12134) ## Summary An incorrect error toast currently shows when cancelling the workflow export from an asset ## Changes - **What**: - skip toast on cancel - add e2e & unit tests - refactor asset tab open helper to wait by default & cleanup usage ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12134-fix-remove-failed-to-export-toast-when-cancelling-export-workflow-35d6d73d3650815b839ff26edd70a472) by [Unito](https://www.unito.io)
dosubot
Bot
added
the
size:S
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1555 passed, 0 failed📊 Browser Reports
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.44 #12422 +/- ##
=============================================
+ Coverage 58.58% 58.65% +0.06%
=============================================
Files 1409 1409
Lines 71712 71714 +2
Branches 18982 19895 +913
=============================================
+ Hits 42011 42061 +50
+ Misses 29197 29149 -48
Partials 504 504
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
AustinMroz
added a commit
that referenced
this pull request
Jun 3, 2026
Backport of #12422 to `cloud/1.45` Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12134 to
core/1.44Automatically created by backport workflow.