fix: remove failed to export toast when cancelling export workflow#12134
Merged
Conversation
- add e2e & unit tests - refactor asset tab open to wait by default & cleanup
Contributor
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a cancellable export result for workflows, updates composable logic to ignore cancelled exports, extends unit and E2E tests (including three new export context-menu tests), adds toast locators and an optional ChangesWorkflow Export with Cancellation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1561 passed, 0 failed · 3 flaky📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/assets/composables/useMediaAssetActions.ts`:
- Around line 568-572: The success/failure toast logic in
useMediaAssetActions.ts incorrectly shows a success when all multi-export items
were cancelled because cancelled items don't increment failed; update the final
notification branching to rely on the succeeded and failed counters (e.g., only
show the success toast if succeeded > 0) and only show the failure toast if
failed > 0; adjust any "all done" / summary message generation to account for
cancelled items (use result.cancelled when computing counts) so a
fully-cancelled run does not produce a success notification. Ensure you update
the code paths that reference result.success, result.cancelled, succeeded, and
failed so the messages and counters reflect cancelled-only outcomes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: df5d35b2-e7bf-4ca7-babe-597fdae25e12
📒 Files selected for processing (6)
browser_tests/fixtures/components/SidebarTab.tsbrowser_tests/fixtures/helpers/ToastHelper.tsbrowser_tests/tests/sidebar/assets.spec.tssrc/platform/assets/composables/useMediaAssetActions.test.tssrc/platform/assets/composables/useMediaAssetActions.tssrc/platform/workflow/core/services/workflowActionsService.ts
📦 Bundle: 5.31 MB gzip 🔴 +30 BDetailsSummary
Category Glance App Entry Points — 31.6 kB (baseline 31.6 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 82.4 kB (baseline 82.4 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 491 kB (baseline 491 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 12 unchanged User & Accounts — 17.6 kB (baseline 17.6 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 62.9 kB (baseline 62.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 9 unchanged Data & Services — 3.14 MB (baseline 3.14 MB) • 🔴 +157 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 367 kB (baseline 367 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.98 MB (baseline 8.98 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 79 unchanged ⚡ Performance Report
No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-11T16:02:44.222Z",
"gitSha": "934f5d12dfde9e41301c65c75537d6113679848a",
"branch": "pysssss/fix-export-cancel-error-toast",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2100.771000000009,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.216999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.63499999999993,
"heapDeltaBytes": 20036648,
"heapUsedBytes": 68969396,
"domNodes": -264,
"jsHeapTotalBytes": 17952768,
"scriptDurationMs": 14.621999999999996,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2037.684000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.224000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.236,
"heapDeltaBytes": 498872,
"heapUsedBytes": 68757080,
"domNodes": -261,
"jsHeapTotalBytes": 21979136,
"scriptDurationMs": 20.927,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1844.8549999999955,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.019999999999996,
"layouts": 12,
"layoutDurationMs": 3.257,
"taskDurationMs": 819.2170000000001,
"heapDeltaBytes": 4159924,
"heapUsedBytes": 53996064,
"domNodes": -259,
"jsHeapTotalBytes": 21979136,
"scriptDurationMs": 130.42999999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1817.9959999999937,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.906,
"layouts": 12,
"layoutDurationMs": 3.2639999999999993,
"taskDurationMs": 773.3939999999999,
"heapDeltaBytes": -4304944,
"heapUsedBytes": 44512744,
"domNodes": -265,
"jsHeapTotalBytes": 16379904,
"scriptDurationMs": 125.20399999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.7629999999726,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.082,
"layouts": 6,
"layoutDurationMs": 0.699,
"taskDurationMs": 356.01200000000006,
"heapDeltaBytes": -4719116,
"heapUsedBytes": 44551644,
"domNodes": -215,
"jsHeapTotalBytes": 19787776,
"scriptDurationMs": 18.049999999999997,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.3439999999837,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.659,
"layouts": 6,
"layoutDurationMs": 0.5500000000000002,
"taskDurationMs": 367.01900000000006,
"heapDeltaBytes": -24006976,
"heapUsedBytes": 44335220,
"domNodes": -209,
"jsHeapTotalBytes": 22241280,
"scriptDurationMs": 23.551000000000002,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 554.6170000000075,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.927999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.86800000000005,
"heapDeltaBytes": 9479848,
"heapUsedBytes": 57981676,
"domNodes": 16,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 59.626,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 552.4350000000595,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.523000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.99100000000004,
"heapDeltaBytes": -4762040,
"heapUsedBytes": 63525360,
"domNodes": 18,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 58.341,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2025.5849999999782,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.309000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.5169999999999,
"heapDeltaBytes": 37727240,
"heapUsedBytes": 97790060,
"domNodes": -264,
"jsHeapTotalBytes": 25776128,
"scriptDurationMs": 88.713,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2018.2929999999715,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.073,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.225,
"heapDeltaBytes": 21761532,
"heapUsedBytes": 77907224,
"domNodes": -260,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 93.179,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2126.3679999999567,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.169999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1094.3480000000002,
"heapDeltaBytes": 25657172,
"heapUsedBytes": 85269112,
"domNodes": -265,
"jsHeapTotalBytes": 6262784,
"scriptDurationMs": 416.499,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2122.4090000000615,
"styleRecalcs": 69,
"styleRecalcDurationMs": 20.402,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1046.605,
"heapDeltaBytes": 1145976,
"heapUsedBytes": 60539512,
"domNodes": -265,
"jsHeapTotalBytes": 1282048,
"scriptDurationMs": 384.277,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3168.7409999999545,
"styleRecalcs": 66,
"styleRecalcDurationMs": 21.238000000000003,
"layouts": 60,
"layoutDurationMs": 7.065,
"taskDurationMs": 1393.164,
"heapDeltaBytes": 35936840,
"heapUsedBytes": 97788468,
"domNodes": -262,
"jsHeapTotalBytes": 36990976,
"scriptDurationMs": 486.81600000000003,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3217.5249999999096,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.307,
"layouts": 60,
"layoutDurationMs": 6.959,
"taskDurationMs": 1348.039,
"heapDeltaBytes": 46535944,
"heapUsedBytes": 108031688,
"domNodes": -265,
"jsHeapTotalBytes": 38039552,
"scriptDurationMs": 479.6259999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2062.112999999954,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.168000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.7229999999998,
"heapDeltaBytes": 39576804,
"heapUsedBytes": 100973652,
"domNodes": -266,
"jsHeapTotalBytes": 33058816,
"scriptDurationMs": 92.086,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2070.3099999999495,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.3500000000001,
"heapDeltaBytes": 44615760,
"heapUsedBytes": 106168848,
"domNodes": -258,
"jsHeapTotalBytes": 32272384,
"scriptDurationMs": 111.843,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 522.2449999999981,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.956999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.818,
"heapDeltaBytes": 8586680,
"heapUsedBytes": 57792568,
"domNodes": 18,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 118.419,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 534.5340000000078,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.93700000000007,
"heapDeltaBytes": 14206076,
"heapUsedBytes": 63748980,
"domNodes": 16,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 118.41999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2005.6379999999763,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.402999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.731,
"heapDeltaBytes": 1898228,
"heapUsedBytes": 67849032,
"domNodes": 20,
"jsHeapTotalBytes": 19755008,
"scriptDurationMs": 17.035999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.4490000000224,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.771,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.653,
"heapDeltaBytes": 796500,
"heapUsedBytes": 63668660,
"domNodes": 21,
"jsHeapTotalBytes": 20803584,
"scriptDurationMs": 16.935,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.438999999953,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.06,
"layouts": 16,
"layoutDurationMs": 4.013,
"taskDurationMs": 719.76,
"heapDeltaBytes": 10678696,
"heapUsedBytes": 59507580,
"domNodes": -259,
"jsHeapTotalBytes": 23457792,
"scriptDurationMs": 94.46799999999999,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.6160000000973,
"styleRecalcs": 74,
"styleRecalcDurationMs": 33.942,
"layouts": 16,
"layoutDurationMs": 4.497,
"taskDurationMs": 729.988,
"heapDeltaBytes": 11946164,
"heapUsedBytes": 61395280,
"domNodes": -265,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 90.422,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1073.7669999999753,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.122,
"layouts": 5,
"layoutDurationMs": 13.530000000000001,
"taskDurationMs": 878.9359999999999,
"heapDeltaBytes": -37178400,
"heapUsedBytes": 114031236,
"domNodes": 12631,
"jsHeapTotalBytes": -21565440,
"scriptDurationMs": 28.428000000000008,
"eventListeners": 1641,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8435.825999999906,
"styleRecalcs": 251,
"styleRecalcDurationMs": 51.43000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3971.958,
"heapDeltaBytes": 85277208,
"heapUsedBytes": 142772724,
"domNodes": -260,
"jsHeapTotalBytes": 75993088,
"scriptDurationMs": 1270.636,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8363.951999999927,
"styleRecalcs": 250,
"styleRecalcDurationMs": 50.787,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3898.322,
"heapDeltaBytes": 83638864,
"heapUsedBytes": 143761236,
"domNodes": -263,
"jsHeapTotalBytes": 63438848,
"scriptDurationMs": 1253.869,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 11933.396000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11904.287,
"heapDeltaBytes": -43993960,
"heapUsedBytes": 172233680,
"domNodes": -8331,
"jsHeapTotalBytes": 27062272,
"scriptDurationMs": 611.2789999999999,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15073.127999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15042.595000000003,
"heapDeltaBytes": 38609104,
"heapUsedBytes": 283154792,
"domNodes": -8329,
"jsHeapTotalBytes": 26013696,
"scriptDurationMs": 692.423,
"eventListeners": -16486,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17437.025000000063,
"styleRecalcs": 112,
"styleRecalcDurationMs": 18.43100000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17391.343,
"heapDeltaBytes": 213482144,
"heapUsedBytes": 456935484,
"domNodes": -3306,
"jsHeapTotalBytes": 210210816,
"scriptDurationMs": 1040.753,
"eventListeners": -16476,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17015.59599999996,
"styleRecalcs": 104,
"styleRecalcDurationMs": 17.774999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16991.543,
"heapDeltaBytes": 26314784,
"heapUsedBytes": 291510908,
"domNodes": -8329,
"jsHeapTotalBytes": 40169472,
"scriptDurationMs": 1062.301,
"eventListeners": -16490,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 448.48000000001775,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.32,
"layouts": 5,
"layoutDurationMs": 1.3619999999999997,
"taskDurationMs": 110.816,
"heapDeltaBytes": 5284732,
"heapUsedBytes": 55144724,
"domNodes": 166,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.289,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 136.9480000000749,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.871000000000002,
"layouts": 5,
"layoutDurationMs": 1.6350000000000002,
"taskDurationMs": 106.50200000000001,
"heapDeltaBytes": 3418680,
"heapUsedBytes": 53672904,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 21.484,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12134 +/- ##
===========================================
- Coverage 73.54% 59.12% -14.43%
===========================================
Files 1516 1407 -109
Lines 87789 71709 -16080
Branches 23637 19892 -3745
===========================================
- Hits 64567 42398 -22169
- Misses 22391 28834 +6443
+ Partials 831 477 -354
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 997 files with indirect coverage changes 🚀 New features to boost your workflow:
|
extend test coverage
dosubot
Bot
added
the
size:S
dante01yoon
approved these changes
May 11, 2026
Collaborator
dante01yoon
left a comment
dante01yoon
left a comment
There was a problem hiding this comment.
Targeted fix with good unit + e2e coverage. The new cancelled flag on exportWorkflowAction is the cleanest way to distinguish a user-cancelled prompt from a real failure, and the bulk path properly skips counting cancellations as failures.
One non-blocking thought left inline on exportMultipleWorkflows.
| } | ||
| } | ||
|
|
||
| // All cancelled |
Collaborator
There was a problem hiding this comment.
suggestion (non-blocking): If a user selects N assets with Comfy.PromptFilename enabled and cancels the first prompt, the loop still walks every remaining asset, popping a fresh prompt each time. Counting cancellations as a soft stop here (e.g. break on result.cancelled) would match user intent better — but it's outside the scope of this fix and the current behavior is at least consistent with what the loop did before the change. Worth a follow-up if QA flags it.
dante01yoon
added a commit
that referenced
this pull request
May 12, 2026
After #12134, AssetsSidebarTab.open() waits for assets on the Generated tab by default. This spec seeds only an input asset, so the Generated tab is empty and the implicit wait times out. Switch to Imported and let waitForAssets(1) gate there instead.
pythongosssss
added
needs-backport
Member
|
@pythongosssss Successfully backported to #12422 |
Member
|
@pythongosssss Successfully backported to #12423 |
github-actions
Bot
removed
the
needs-backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An incorrect error toast currently shows when cancelling the workflow export from an asset
Changes
┆Issue is synchronized with this Notion page by Unito