Skip to content

[backport cloud/1.44] fix: remove failed to export toast when cancelling export workflow#12423

Open
comfy-pr-bot wants to merge 1 commit into
cloud/1.44from
backport-12134-to-cloud-1.44
Open

[backport cloud/1.44] fix: remove failed to export toast when cancelling export workflow#12423
comfy-pr-bot wants to merge 1 commit into
cloud/1.44from
backport-12134-to-cloud-1.44

Conversation

@comfy-pr-bot
Copy link
Copy Markdown
Member

Backport of #12134 to cloud/1.44

Automatically created by backport workflow.

…12134)

## Summary

An incorrect error toast currently shows when cancelling the workflow
export from an asset

## Changes

- **What**: 
- skip toast on cancel
- add e2e & unit tests
- refactor asset tab open helper to wait by default & cleanup usage

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12134-fix-remove-failed-to-export-toast-when-cancelling-export-workflow-35d6d73d3650815b839ff26edd70a472)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label May 22, 2026
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 22, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 05/22/2026, 11:31:12 AM UTC

Links

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

🎭 Playwright: ✅ 1549 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1530 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.44   #12423   +/-   ##
=============================================
  Coverage              ?   58.65%           
=============================================
  Files                 ?     1409           
  Lines                 ?    71714           
  Branches              ?    18984           
=============================================
  Hits                  ?    42061           
  Misses                ?    29149           
  Partials              ?      504           
Flag Coverage Δ
unit 58.65% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...latform/assets/composables/useMediaAssetActions.ts 76.48% <100.00%> (ø)
...m/workflow/core/services/workflowActionsService.ts 65.62% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants