Return ServiceFault for bad subscription ID and return ack results in PublishResult#1991
Open
kohtala wants to merge 2 commits into
Open
Return ServiceFault for bad subscription ID and return ack results in PublishResult#1991kohtala wants to merge 2 commits into
kohtala wants to merge 2 commits into
Conversation
The Create/Modify/DeleteMonitoredItemsRequests returned Good service result with bad SubscriptionId and each operation result was BadSubscriptionIdInvalid. The OPC-UA specification however asks for the BadSubscriptionIdInvalid to be returned as a service result.
Member
|
@kohtala some lint issues here |
The PublishResponse Results was always empty while the specification asks for it to return the results of subscription acknowledgements. Typing did not find the generated parameters due to missing ua definition.
kohtala
force-pushed
the
createmonitoreditems-badsubscriptionid
branch
from
34a3a2b to
c051e8b
Compare
Contributor
Author
@oroulet, I had missed what had happened earlier and only saw the error today. It is now fixed to pass. VSCode is complaining the It might be the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Create/Modify/DeleteMonitoredItemsRequests returned Good service result with bad SubscriptionId and each operation result was BadSubscriptionIdInvalid. The OPC-UA specification however asks for the BadSubscriptionIdInvalid to be returned as a service result.
The PublishResponse Results was always empty while the specification asks for it to return the results of subscription acknowledgements.