fix(rule-4.1.4): handle allow out ports set to 'all' correctly - #342
Open
tmeckel wants to merge 1 commit into
Open
fix(rule-4.1.4): handle allow out ports set to 'all' correctly#342tmeckel wants to merge 1 commit into
tmeckel wants to merge 1 commit into
Conversation
Signed-off-by: Thomas Meckel <tmeckel@users.noreply.github.com>
tmeckel
force-pushed
the
fix/rule-4.1.4-all
branch
from
May 18, 2026 13:15
e2a0107 to
2448d64
Compare
Contributor
|
Can you please merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Changed
tasks/section_4/cis_4.1.x.ymlso the loop in the 4.1.5 "Custom ports" task uses an empty list when ubtu22cis_ufw_allow_out_ports == 'all', instead of looping over the raw value.Issue Fixes:
Closes: #328
Enhancements:
N/A
How has this been tested?:
Local image builder