Introduce Role-based interfaces for wallet#1083
Open
yyforyongyu wants to merge 309 commits into
Open
Conversation
yyforyongyu
force-pushed
the
interface-wallet
branch
4 times, most recently
from
23ebf86 to
afdbbd9
Compare
yyforyongyu
force-pushed
the
interface-wallet
branch
2 times, most recently
from
b1c1a55 to
12b10a8
Compare
yyforyongyu
force-pushed
the
interface-wallet
branch
2 times, most recently
from
2b3d4cd to
3c66ae5
Compare
yyforyongyu
force-pushed
the
interface-wallet
branch
from
3c66ae5 to
eedd68a
Compare
yyforyongyu
force-pushed
the
interface-wallet
branch
8 times, most recently
from
071e0fd to
7fb0543
Compare
yyforyongyu
force-pushed
the
interface-wallet
branch
4 times, most recently
from
30cd22f to
3f9e5c8
Compare
yyforyongyu
force-pushed
the
interface-wallet
branch
3 times, most recently
from
ff3a0ae to
6382f26
Compare
yyforyongyu
force-pushed
the
interface-wallet
branch
2 times, most recently
from
31a6cff to
a92782d
Compare
yyforyongyu
force-pushed
the
interface-wallet
branch
from
1cfc2cb to
562c06e
Compare
Collaborator
Author
|
#1153 introduced a new tab width, which cause the lastest push to fail the linter CI - this is fine as they are fixed in a later PR. |
yyforyongyu
force-pushed
the
interface-wallet
branch
from
c1420c1 to
674fef3
Compare
We now use `Locked` field from `Credit` and `CreditRecord`.
We now remove the usage of the deprecated methods `AccountNumber` and `requireChainClient`.
This commit fixes a race condition where concurrent address generation
requests could result in duplicate addresses. The issue was caused by
relying on the in-memory account index cache, which could be stale
during a pending database commit.
We now resolve this by:
1. Always fetching the 'next index' directly from the database's
consistent transaction view in 'nextAddresses' and 'extendAddresses'.
2. Implementing a monotonic check in the 'OnCommit' cache update hook,
ensuring the in-memory cache only moves forward and never regresses
if concurrent transactions commit out of order.
3. Adding a 'getNextIndex' helper to encapsulate the authoritative
index retrieval logic.
With this fix at the manager level, the broad 'newAddrMtx' lock in the
wallet package is no longer necessary.
This commit refactors several functions to reduce their cyclomatic complexity, making the code easier to read and maintain.
We now complete the implementation of `ImportAccount` by removing the usage of the deprecated methods. We also identified a few methods that should not be deprecated.
We now remove the usage of the old `testWallet`.
This specifies different ways the wallet can be created.
This manager replaces the old wallet loader to handle the creation and loading the wallets.
After rebasing the interface-wallet branch onto the btcd-v2 module upgrade, the feature-only files still carried v1 btcd import paths and the v1 `btcutil.Address` API. This commit completes the migration: - Rewrite remaining v1 btcd import paths to their v2 equivalents (btcutil->btcutil/v2, chaincfg->chaincfg/v2, chaincfg/chainhash-> chainhash/v2, txscript->txscript/v2, wire->wire/v2, btcutil/psbt-> psbt/v2, btcutil/gcs[/builder]->btcutil/v2/gcs[/builder]). - Move the address types and constructors off btcutil onto the new github.com/btcsuite/btcd/address/v2 package. - Restore the local replace directives for the feature-modified wtxmgr and wallet/txsizes submodules and run `go mod tidy`. - Add the SubmitPackage method to the wallet mockChain so it satisfies the SubmitPackage addition to chain.Interface. - Drop a duplicated hasMinConfs/calcConf pair left over from the deprecated-method file split.
yyforyongyu
force-pushed
the
interface-wallet
branch
from
cca6313 to
78ac6ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open this PR to track rebase conflicts.
TODO: add descriptions and link PRs and issues.