fix: Always restore process umask#3939
Merged
Merged
Conversation
CerealBoy
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure the process umask is restored, even if there is a failure to listen on the socket.
Context
https://slopcannon.tail952194.ts.net/lachlan/deepsec-buildkite-agent/MEDIUM/agent-other-insecure-permissions-0da6fccd11.md
Changes
Add a deferred
Umask(oldUmask)immediately after checking the error from the first umask.Setting the same umask twice (defer + usual call after creating the socket) is fine.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
The bug was found by deepsec, the fix is by me.