Skip to content

fix: Always restore process umask #3939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJosh9000 merged 1 commit into from
May 25, 2026
+4 −1
Merged

fix: Always restore process umask #3939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion kubernetes/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,13 @@ func (r *Runner) Run(ctx context.Context) error {
}
r.mux.Handle(rpc.DefaultRPCPath, r.server)

oldUmask, err := Umask(0) // set umask of socket file to 0o777 (world read-write-executable)
// Set umask to 0, so the socket is created with mode 0o777 (world
// read-write-executable)
oldUmask, err := Umask(0)
if err != nil {
return fmt.Errorf("failed to set socket umask: %w", err)
}
defer Umask(oldUmask) //nolint:errcheck // Best-effort cleanup on failure
l, err := (&net.ListenConfig{}).Listen(ctx, "unix", r.conf.SocketPath)
if err != nil {
return fmt.Errorf("failed to listen: %w", err)
Expand Down