all: enable revive linter#1025
Draft
joshuasing wants to merge 1 commit into
Draft
Conversation
joshuasing
requested review from
a team,
ClaytonNorthey92 and
marcopeereboom
as code owners
github-actions
Bot
added
area: bfg
joshuasing
added
type: enhancement
joshuasing
force-pushed
the
joshua/revive
branch
2 times, most recently
from
c8cf253 to
2f1aae0
Compare
marcopeereboom
requested changes
May 13, 2026
Contributor
marcopeereboom
left a comment
marcopeereboom
left a comment
There was a problem hiding this comment.
I hate this but will allow it but not before continuum goes in (and maybe the ordinal PR). This is way too much churn for large PRs.
ClaytonNorthey92
approved these changes
May 13, 2026
Contributor
|
@joshuasing , I have no objections, but could we wait to merge until after the PR @marcopeereboom is getting in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable
revive(https://github.com/mgechev/revive) linter in golangci-lint.This linter contains a bunch of rules focusing on: code readability, maintainability, best practices, and correctness. It can be verbose (e.g. var-naming, unused) but can often catch very subtle bugs caused by the wrong variable being used, etc.
Some rules are based on recommendations from the Go team that are enforced in Go itself, e.g. from https://go.dev/wiki/CodeReviewComments
Changes
revivelinter in.golangci.yaml