fix(github): handle x86 release assets as x64 fallback#10103
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback mechanism to treat x86 assets as low-priority options for x86_64 targets when no exact x64 match is found. It also adds support for recognizing ".cert" extensions as non-binary assets, and expands the recognized OS patterns to include "manylinux", "musllinux", and "osx". Relevant unit tests have been added to verify these changes. I have no feedback to provide as there are no review comments to address.
Greptile SummaryThis PR addresses a real-world install failure for tools (e.g. opengrep) that tag their x86-64 release artifacts as simply
Confidence Score: 5/5The change is a small, isolated scoring adjustment in asset selection with no data-loss or security implications; all affected code paths are covered by existing and new tests. The logic is minimal and correctness follows directly from the score ordering (5 < 50, both > 0) and the pre-existing filter in pick_best_asset. Real 32-bit x86 targets are unaffected because they hit the exact-match branch (score 50) before the new fallback branch. The three test scenarios added exercise the key cases with no gaps visible from the implementation. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(github): narrow x86 fallback scope" | Re-trigger Greptile |
e287d7f to
0a0a5fb
Compare
Summary
x86to serve as a low-priority fallback on x64 targetsSplit scope
Discussion
Part of #10033.
Tests
git diff --check upstream/main...HEADcargo test test_x86_asset_is_x64_fallback; local test build stops before this test in untouchedsrc/backend/aqua.rstest code with the existingOption<bool>/boolmismatch aroundcomplete_windows_ext.