fix(github): penalize certificate assets as metadata#10158
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for recognizing and penalizing .cert certificate files in the asset matcher, ensuring they are not incorrectly prioritized over actual binaries. It also adds corresponding unit tests to verify this behavior. The reviewer suggested also adding .cer as it is another common certificate extension.
Greptile SummaryThis PR adds
Confidence Score: 5/5A two-line addition to an extension allowlist with direct test coverage — no functional risk. The change is a minimal, self-contained addition of two certificate file extensions to an existing penalty list. The logic and placement are consistent with surrounding entries ( No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(github): penalize cer assets as meta..." | Re-trigger Greptile |
Summary
.certand.cerrelease assets like other metadata/signature files during asset scoringExtracted from #10103 so this metadata scoring fix can land separately from the x86 fallback work. The
.cerextension was added from review feedback because it is another common certificate asset extension.Tests
cargo test test_metadata_penaltycargo fmt --check