DRIVERS-3535 - Client Backpressure with retryAfterMS#1953
Open
NoahStapp wants to merge 16 commits into
Open
Conversation
tadjik1
reviewed
Jun 18, 2026
tadjik1
reviewed
Jun 18, 2026
tadjik1
reviewed
Jun 18, 2026
tadjik1
reviewed
Jun 18, 2026
tadjik1
reviewed
Jun 18, 2026
Co-authored-by: Sergey Zelenov <sergey.zelenov@mongodb.com>
tadjik1
reviewed
Jun 18, 2026
tadjik1
left a comment
tadjik1
left a comment
Member
There was a problem hiding this comment.
Thanks @NoahStapp, everything looks good! I will keep an eye on retryAfterMS max value, once it's set I'll approve this PR.
blink1073
requested changes
Jun 18, 2026
Co-authored-by: Steven Silvester <steve.silvester@mongodb.com>
Contributor
Author
|
After further discussion with Server, I've simplified the backoff calculation formula to remove the custom jitter for |
Member
|
As a note, the two failing checks should be fixed by #1958 |
blink1073
reviewed
Jun 24, 2026
| retry_after_ms = exc.retry_after_ms | ||
| if retry_after_ms: | ||
| retry_after = retry_after / 1000 # Convert from milliseconds to seconds | ||
| backoff = jitter * min(MAX_BACKOFF, retry_after * 2 ** (attempt - 1)) |
Member
There was a problem hiding this comment.
jitter is undefined in this if block, should it be hoisted to above it?
blink1073
reviewed
Jun 24, 2026
|
|
||
| # If present on the error, retryAfterMS sets the base backoff | ||
| retry_after_ms = exc.retry_after_ms | ||
| if retry_after_ms: |
Member
There was a problem hiding this comment.
I think the retry_after should be set as BASE_BACKOFF, then set to the new value if retry_after_ms is given, then use a single line to set the backoff
Contributor
Author
There was a problem hiding this comment.
🙏 even more concise, thanks!
blink1073
approved these changes
Jun 24, 2026
tadjik1
approved these changes
Jun 25, 2026
jyemin
requested changes
Jun 25, 2026
jyemin
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please complete the following before merging:
clusters).