[#73925] "Move to backlog bucket" and "move to backlog inbox" menu option

[dombesz]

Ticket

https://community.openproject.org/wp/73925

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[Copilot]

Pull request overview

This PR extends the Backlogs work package card “Move” menu by adding explicit actions to move a work package to the backlog inbox and to a backlog bucket (via a new async dialog), including routing, UI components, and test coverage.

Changes:

• Added “Move to inbox” and “Move to backlog bucket” entries to the work package action menu, gated by permissions and availability.
• Introduced a new move_to_backlog_bucket_dialog endpoint and Backlogs::MoveToBacklogBucketDialogComponent to select a target bucket.
• Expanded controller/component/routing/feature specs to cover the new menu items and dialog behavior.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
modules/backlogs/spec/support/pages/backlog.rb	Adds page-object helpers for bucket assertions and unifies menu interaction helpers for work packages.
modules/backlogs/spec/routing/backlogs/work_packages_routing_spec.rb	Adds routing coverage for the new backlog bucket dialog endpoint.
modules/backlogs/spec/features/work_packages/move_to_backlog_spec.rb	New JS feature spec covering moving to inbox/bucket/sprint across different sources.
modules/backlogs/spec/features/inbox_column_spec.rb	Updates to use the generalized work package move-menu helpers.
modules/backlogs/spec/features/backlogs/edit_spec.rb	Removes redundant sprint-to-sprint move coverage now handled in the new spec.
modules/backlogs/spec/controllers/backlogs/work_packages_controller_spec.rb	Adds controller coverage for other_buckets_exist and the new dialog action (incl. permissions and all=1).
modules/backlogs/spec/components/backlogs/work_package_card_menu_component_spec.rb	Extends menu component spec for new items/visibility rules and all=1 propagation.
modules/backlogs/spec/components/backlogs/move_to_backlog_bucket_dialog_component_spec.rb	New component spec for dialog rendering and option filtering.
modules/backlogs/lib/open_project/backlogs/engine.rb	Extends manage_sprint_items permission mapping to include the new dialog action.
modules/backlogs/config/routes.rb	Adds move_to_backlog_bucket_dialog route.
modules/backlogs/config/locales/en.yml	Adds i18n strings for the new dialog title and menu entries.
modules/backlogs/app/controllers/backlogs/work_packages_controller.rb	Computes other_buckets_exist and serves the new backlog bucket dialog via turbo-stream.
modules/backlogs/app/components/backlogs/work_package_card_menu_component.rb	Adds menu visibility predicates and a required other_buckets_exist initializer argument.
modules/backlogs/app/components/backlogs/work_package_card_menu_component.html.erb	Renders the new “Move to inbox” (PUT) and “Move to backlog bucket” (async dialog) items.
modules/backlogs/app/components/backlogs/sprint_dialog_component.html.erb	Removes redundant data: { turbo: true } from the submit button.
modules/backlogs/app/components/backlogs/move_to_sprint_dialog_component.html.erb	Removes redundant data: { turbo: true } from the submit button.
modules/backlogs/app/components/backlogs/move_to_backlog_bucket_dialog_component.rb	New dialog component that lists eligible buckets and excludes the current bucket.
modules/backlogs/app/components/backlogs/move_to_backlog_bucket_dialog_component.html.erb	New dialog UI with a bucket select and PUT submission to the existing move endpoint.
modules/backlogs/app/components/backlogs/bucket_dialog_component.html.erb	Removes redundant data: { turbo: true } from the submit button.

[Copilot]

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

[myabc]

Works well.

N.B. it was quite difficult to review modules/backlogs/spec/support/pages/backlog.rb because of the various renames and cleanup. I am assuming that there were no significant changes.

Otherwise, my only feedback is nitpicks and minor suggestions, e.g.:

• unnecessary wait_for_network_idle where we are already calling wait_for_turbo_stream
• preferring Capybara selectors that don't require assembling long CSS queries
• and Capybara Accessible Selector's modal selector